Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameters for ECAL MLDQM [14_0_X] #44930

Merged
merged 1 commit into from
May 10, 2024

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented May 8, 2024

PR description:

This PR changes certain parameters and thresholds for the ML based DQM quality plot in ECAL to better accommodate the high luminosity runs in 2024.

PR validation:

The PR was validated by running the online Ecal DQM configuration and the resultant plots were examined by uploading the output file to a DQM test gui. The new plots look reasonable.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 14_0_X which is currently used in production. Master PR is #44929

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

A new Pull Request was created by @abhih1 for CMSSW_14_0_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@tjavaid, @rvenditti, @syuvivida, @nothingface0, @cmsbuild, @antoniovagnerini can you please review it and eventually sign? Thanks.
@thomreis, @wang0jin, @ReyerBand, @rchatter, @argiro this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented May 9, 2024

please test

@tjavaid
Copy link

tjavaid commented May 9, 2024

backport of #44929

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6282c5/39324/summary.html
COMMIT: bf0596d
CMSSW: CMSSW_14_0_X_2024-05-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44930/39324/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented May 10, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2466a2b into cms-sw:CMSSW_14_0_X May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants